DOC : DA028241 - getSituationRatio() core-patch debt + credit-note scope limit (suivi #748)#749
Merged
ATM-NicolasV merged 2 commits intoJun 19, 2026
Conversation
…ation of getSituationRatio() Make explicit, in the getSituationRatio() docblock and in ChangeLog_loukta, two things flagged during PR #748 review: - O3 (core debt): this method + its consumers in core/lib/pdf.lib.php are a Loukta-local backport of upstream PR Dolibarr#36503 and will be overwritten on the next core upgrade; drop them once Dolibarr#36503 lands upstream. - O4 (scope): the fix only corrects the mode-1 denominator and does NOT handle credit notes (get_prev_progress() still adds credit-note percents), so a situation cycle containing a credit note may still yield a wrong/negative delta. Documentation only, no logic change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…kers Bracket the whole getSituationRatio() method (added as a Loukta-local core backport of upstream PR Dolibarr#36503) with: // LOUKTA DA028241 - START ... // LOUKTA DA028241 - END so the local core patch can be located and removed in one block on the next Dolibarr core upgrade. The markers also cover the previously-merged PR #748 denominator change, which was not wrapped. Comment-only, no logic change. Committed with --no-verify (claudemd gate blocks on missing root CLAUDE.md; bypass authorized by user). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suivi documentaire de la PR #748 (déjà mergée). Documentation seule, aucune logique modifiée.
Formalise deux points relevés en revue de #748 :
FactureLigne::getSituationRatio()+ ses consommateurs danscore/lib/pdf.lib.phpsont un patch core local (backport de l'upstream PR FIX: when INVOICE_USE_SITUATION === 2, some libs still use the old algorithms Dolibarr/dolibarr#36503, cf. DA027405). Ils seront écrasés à chaque montée de version du core → à reporter, ou de préférence à supprimer une fois FIX: when INVOICE_USE_SITUATION === 2, some libs still use the old algorithms Dolibarr/dolibarr#36503 mergé en amont.get_prev_progress()additionne encore (+=) les pourcentages des avoirs, donc un cycle de situation contenant un avoir peut toujours produire un delta faux (voire négatif).Modifs : docblock de
getSituationRatio()+ ligneNOTEdansChangeLog_loukta.🤖 Generated with Claude Code